[PATCH] D87018: [DebugInfo] Fix emitting DWARF64 DWO compilation units and string offset tables (9/19).

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/debug-info-dwo-dwarf64.ll:7
+; CHECK:      .debug_info.dwo contents:
+; CHECK-NEXT: Compile Unit: length = 0x{{([[:xdigit:]]{16})}}, format = DWARF64, version = 0x0005, unit_type = DW_UT_split_compile, abbr_offset = 0x0000, addr_size = 0x08
+
----------------
dblaikie wrote:
> Perhaps the abbr_offset should be printed with more digits to reflect the longer encoding size? (I think that's been the general approach elsewhere in the dump output format, yes?)
Optional more concise alternative to the existing regex, making use of FileCheck's new precision for numeric variables (strictly speaking, this pattern would allow a 17-digit number with no leading 0s, but that might be beyond what's needed). Not sure if you'd prefer it or not - happy either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87018/new/

https://reviews.llvm.org/D87018