[PATCH] D87018: [DebugInfo] Fix emitting DWARF64 DWO compilation units and string offset tables (9/19).

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/DebugInfo/X86/debug-info-dwo-dwarf64.ll:7
+; CHECK:      .debug_info.dwo contents:
+; CHECK-NEXT: Compile Unit: length = 0x{{([[:xdigit:]]{16})}}, format = DWARF64, version = 0x0005, unit_type = DW_UT_split_compile, abbr_offset = 0x0000, addr_size = 0x08
+
----------------
Perhaps the abbr_offset should be printed with more digits to reflect the longer encoding size? (I think that's been the general approach elsewhere in the dump output format, yes?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87018/new/

https://reviews.llvm.org/D87018