[PATCH] D87009: [DebugInfo] Fix DIE value emitters to be compatible with DWARF64 (2/19).

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 18:23:00 PDT 2020


ikudrin added a comment.

In D87009#2255174 <https://reviews.llvm.org/D87009#2255174>, @dblaikie wrote:

> In D87009#2253973 <https://reviews.llvm.org/D87009#2253973>, @ikudrin wrote:
>
>> That would require to update a particular method several times and potentially would leave it in a partially updated state because some code paths are hard to reach.
>
> Could you explain this in more detail?

Let's take, for example, `DIEExpr`. As far as I can find, with `DW_FORM_sec_offset` it is used only in the `DebugInfo/DWARF` unit tests, in `dwarfgen::DIE::addStrOffsetsBaseAttribute()`. If we took the approach with end-to-end functional testing, this class would not be updated. And the path is not simple to track, by the way.

Other classes in this patch are used to emit compilation units, so moving the changes there would bloat that patch up, making it less focused and harder to track how each individual change is tested because, when looking to the test source, it is not evident which attributes use a particular class to emit their values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87009/new/

https://reviews.llvm.org/D87009



More information about the llvm-commits mailing list