[PATCH] D87009: [DebugInfo] Fix DIE value emitters to be compatible with DWARF64 (2/19).

Thu Sep 3 12:08:38 PDT 2020

dblaikie added a comment.

In D87009#2253973 <https://reviews.llvm.org/D87009#2253973>, @ikudrin wrote:

> In D87009#2252622 <https://reviews.llvm.org/D87009#2252622>, @dblaikie wrote:
>
>> Might be too fine-grained and better off rolled into whatever patch exercises this functionality when emitting assembly.
>
> That would require to update a particular method several times and potentially would leave it in a partially updated state because some code paths are hard to reach.

Could you explain this in more detail?

I'm not really comfortable with updating the size calculation while not updating the emission calculation - that seems like this code is then currently unusable as-committed, so not a great granularity to commit at. I really appreciate all the work you've done in splitting this patch series up, but it might be a bit too fine-grained overall.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87009/new/

https://reviews.llvm.org/D87009