[PATCH] D87020: [DebugInfo] Fix emitting DWARF64 .debug_loclists sections (13/19).

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: llvm/test/CodeGen/X86/debug-loclists.ll:26
+; DWARF32-NEXT:   DW_AT_location [DW_FORM_loclistx]   (indexed (0x1) loclist = 0x00000029:
+; DWARF64-NEXT:   DW_AT_location [DW_FORM_loclistx]   (indexed (0x1) loclist = 0x0000003d:
+; CHECK-NEXT:       [0x0000000000000000, 0x0000000000000003) ".text._Z2f1ii": DW_OP_consts +5, DW_OP_stack_value)
----------------
dblaikie wrote:
> Should this dump the loclist = XXX value with a wider encoding, since it's stored wider? (I think that's generally the idea you've had for dumping, that the dumper should dump the width of the encoded field?)
In general, yes, but with some exceptions. In particular, when we show the offset of the information we dump, like the case we have here. The actual encoding of the value in the field is `ULEB`, and the stored value is `1`, while it indirectly points to offset `0x39` in `.debug_loclists`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87020/new/

https://reviews.llvm.org/D87020