[PATCH] D87020: [DebugInfo] Fix emitting DWARF64 .debug_loclists sections (13/19).

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good.

(note to self/anyone: Be nice if this code wasn't loclist specific/was instead shared with the rnglist handling too)



================
Comment at: llvm/test/CodeGen/X86/debug-loclists.ll:26
+; DWARF32-NEXT:   DW_AT_location [DW_FORM_loclistx]   (indexed (0x1) loclist = 0x00000029:
+; DWARF64-NEXT:   DW_AT_location [DW_FORM_loclistx]   (indexed (0x1) loclist = 0x0000003d:
+; CHECK-NEXT:       [0x0000000000000000, 0x0000000000000003) ".text._Z2f1ii": DW_OP_consts +5, DW_OP_stack_value)
----------------
Should this dump the loclist = XXX value with a wider encoding, since it's stored wider? (I think that's generally the idea you've had for dumping, that the dumper should dump the width of the encoded field?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87020/new/

https://reviews.llvm.org/D87020