[PATCH] D85911: libclc: spirv: Add various functions

Wed Sep 2 18:02:48 PDT 2020

jvesely added a comment.

In D85911#2250154 <https://reviews.llvm.org/D85911#2250154>, @daniels wrote:

> In D85911#2250140 <https://reviews.llvm.org/D85911#2250140>, @jvesely wrote:
>
>> so the translator can translate calls to `fma`, but not call to `llvm.fma`? that's weird. Please add that in a comment. Otherwise LGTM.
>
> Right, it doesn't translate the LLVM intrinsics, only what's covered by the spec (see e.g. the OpenCL extension opcode definitions) as builtins, so it can be precise about what they mean and require.
>
> Would you like the comment in `fma.inc` or in a commit message?

I've thought about this. I think having a section on expected uses of all targets in README would be the best alternative. Feel free to go ahead with this patch as is. README.TXT is hopelessly out of date anyway so updating it should be done in a separate patch anyway.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85911/new/

https://reviews.llvm.org/D85911