[PATCH] D85911: libclc: spirv: Add various functions

Daniel Stone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 10:57:44 PDT 2020


daniels added a comment.

In D85911#2250140 <https://reviews.llvm.org/D85911#2250140>, @jvesely wrote:

> so the translator can translate calls to `fma`, but not call to `llvm.fma`? that's weird. Please add that in a comment. Otherwise LGTM.

Right, it doesn't translate the LLVM intrinsics, only what's covered by the spec (see e.g. the OpenCL extension opcode definitions) as builtins, so it can be precise about what they mean and require.

Would you like the comment in `fma.inc` or in a commit message?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85911/new/

https://reviews.llvm.org/D85911



More information about the llvm-commits mailing list