[PATCH] D86651: [MemCpyOpt] Preserve MemorySSA.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 04:39:46 PDT 2020


fhahn marked 4 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp:421
+      auto *NewAccess =
+          MSSAU->createMemoryAccessAfter(AMemSet, LastDef, LastAcc);
+      MSSAU->insertDef(cast<MemoryDef>(NewAccess), /*RenameUses=*/true);
----------------
asbirlea wrote:
> `assert (LastDef && "Must exist.");`
Done, added an assert for both LastAcc and LastDef.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86651/new/

https://reviews.llvm.org/D86651



More information about the llvm-commits mailing list