[PATCH] D86651: [MemCpyOpt] Preserve MemorySSA.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 04:38:43 PDT 2020


fhahn updated this revision to Diff 289394.
fhahn added a comment.



In D86651#2251167 <https://reviews.llvm.org/D86651#2251167>, @asbirlea wrote:

> I was working on having MemCpyOpt preserve and use MSSA, in order to replace the use of MemDepAnalysis entirely. But I'm happy with having MSSA preserved first :-).

I agree that MemCpyOpt is another good candidate the use MSSA and I think it should be possible to share some of the analysis/approach from DSE + MemorySSA to also remove the BB only limitation.

But preserving it is a relatively small step compared to that so we can take the initial step with DSE + MemorySSA :)

> Some quick comments below.

Thanks, should be addressed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86651/new/

https://reviews.llvm.org/D86651

Files:
  llvm/include/llvm/Transforms/Scalar/MemCpyOptimizer.h
  llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp
  llvm/test/Transforms/MemCpyOpt/preserve-memssa.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86651.289394.patch
Type: text/x-patch
Size: 19941 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200902/b5964ba4/attachment.bin>


More information about the llvm-commits mailing list