[PATCH] D86907: Fix for PR46384. Failure on weak dllimport.

[Warren Ristow via Phabricator via llvm-commits]

wristow added inline comments.


================
Comment at: llvm/test/Verifier/weak-dllimport.ll:1
+; RUN: opt -verify < %s
+; ModuleID = 'wd.cpp'
----------------
Sunil_Srivastava wrote:
> wristow wrote:
> > This test seems somewhat complicated.  Can it be simplified significantly, and still trigger the problem?
> Yes it can be simplified. Most of the executable code and attributes can go away. It will lose its connection to the source though. Is that preferred ?
IMO, yes that's preferred.

Leaving a fragment of source in as a comment to show how the situation came about is fine.  But simplifying the IR of the test so it focuses on the problem makes it clearer to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86907/new/

https://reviews.llvm.org/D86907