[PATCH] D86907: Fix for PR46384. Failure on weak dllimport.

Sunil Srivastava via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 12:58:08 PDT 2020


Sunil_Srivastava added inline comments.


================
Comment at: llvm/test/Verifier/weak-dllimport.ll:1
+; RUN: opt -verify < %s
+; ModuleID = 'wd.cpp'
----------------
wristow wrote:
> This test seems somewhat complicated.  Can it be simplified significantly, and still trigger the problem?
Yes it can be simplified. Most of the executable code and attributes can go away. It will lose its connection to the source though. Is that preferred ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86907/new/

https://reviews.llvm.org/D86907



More information about the llvm-commits mailing list