[PATCH] D86746: [lld-macho] Weak locals should be relaxed too
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 27 16:34:56 PDT 2020
int3 added inline comments.
================
Comment at: lld/MachO/SyntheticSections.cpp:269
+bool macho::needsBinding(const Symbol *sym) {
+ if (isa<DylibSymbol>(sym)) {
----------------
smeenai wrote:
> I don't have strong feelings about this either way, but would this be better as a method on `Symbol` vs. an out-of-line function?
I put it here since its logic is pretty similar (and related) to that in `addNonLazyBindingEntries` below
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86746/new/
https://reviews.llvm.org/D86746
More information about the llvm-commits
mailing list