[PATCH] D86746: [lld-macho] Weak locals should be relaxed too

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM; good catch.



================
Comment at: lld/MachO/SyntheticSections.cpp:269
 
+bool macho::needsBinding(const Symbol *sym) {
+  if (isa<DylibSymbol>(sym)) {
----------------
I don't have strong feelings about this either way, but would this be better as a method on `Symbol` vs. an out-of-line function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86746/new/

https://reviews.llvm.org/D86746