[PATCH] D69411: [MC] Resolve the difference of symbols in consecutive MCDataFragements

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/MC/ARM/directive_if_offset_error.s:1
+@ RUN: not llvm-mc -filetype=obj -triple arm-linux-gnueabihf %s -o /dev/null 2>&1 | FileCheck %s
+
----------------
jcai19 wrote:
> MaskRay wrote:
> > See ELF/reloc-directive.s
> > 
> > You can use --defsym=ERR=1 to merge the tests into directive-if-sub.s
> --defsym=ERR=1 does not seem to work if I move the code from this file into directive-if-subtraction.s, as the run commands still fail. Maybe I am missing something? Also directive-if-subtraction.s requires armv7a so this run command will fail once I make the move. 
See `ELF/reloc-directive.s` for an example.

```
# RUN: not llvm-mc ....... | FileCheck %s --check-prefix=ERR
normal assembly

.ifdef ERR
# ERR: {{.*}}.s:[[#@LINE+1]]:10: error: expected comma
error line
.endif
```

I think it is clearer to place working and non-working examples in one file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69411/new/

https://reviews.llvm.org/D69411