[PATCH] D69411: [MC] Resolve the difference of symbols in consecutive MCDataFragements

[Jian Cai via Phabricator via llvm-commits]

jcai19 added a comment.

@maskray



================
Comment at: llvm/include/llvm/MC/MCFragment.h:74
+  // the fragment is not in any subsection
+  unsigned SubsectionNumber = 0;
+
----------------
MaskRay wrote:
> Move below LayoutOrder. sizeof(MCDataFragment) will not change
> 
> Alternatively, disable the folding for Mach-O because this is too subtle (if getSubsectionViaSymbols())
Thanks for all the comments! Can you please elaborate this one? Are you suggesting to move SubsectionNumber right after LayoutOrder?


================
Comment at: llvm/test/MC/ARM/directive_if_offset_error.s:1
+@ RUN: not llvm-mc -filetype=obj -triple arm-linux-gnueabihf %s -o /dev/null 2>&1 | FileCheck %s
+
----------------
MaskRay wrote:
> See ELF/reloc-directive.s
> 
> You can use --defsym=ERR=1 to merge the tests into directive-if-sub.s
--defsym=ERR=1 does not seem to work if I move the code from this file into directive-if-subtraction.s, as the run commands still fail. Maybe I am missing something? Also directive-if-subtraction.s requires armv7a so this run command will fail once I make the move. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69411/new/

https://reviews.llvm.org/D69411