[PATCH] D77029: Fix out-of-bounds BitVector access in RegScavenger

Thu Aug 27 07:05:28 PDT 2020

arsenm added a comment.

In D77029#2224981 <https://reviews.llvm.org/D77029#2224981>, @bmoody wrote:

> In D77029#2107348 <https://reviews.llvm.org/D77029#2107348>, @efriedma wrote:
>
>> Given the code is currently "dead", this change is essentially adding new functionality. I don't want to do that without appropriate tests.
>
> Very understandable.  I've spent some more time trying to derive a codegen test for this change but I'm having a hard time as I don't have much experience with the codegen side of llvm.  Could you recommend someone with knowledge of this code who might be able to help me?

Did you try adding the unreachable as I suggested above?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77029/new/

https://reviews.llvm.org/D77029