[PATCH] D86317: IRBuilder: add CreateIntrinsicByType method

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.h:90
+  /// Overloaded types are deduced from \p RetTy and \p ArgTys.
+  Function *getDeclarationByType(Module *M, ID id, Type *RetTy,
+                                 ArrayRef<Type *> ArgTys,
----------------
This should probably elaborate a bit more on how this is different. I'm also not sure ByType is the right name. Maybe getDeclarationWithInferredType?


================
Comment at: llvm/include/llvm/IR/Intrinsics.h:215
     MatchIntrinsicTypes_NoMatchArg = 2,
+    MatchIntrinsicTypes_NoMatchVarArg = 3,
   };
----------------
Comment what this is for?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86317/new/

https://reviews.llvm.org/D86317