[PATCH] D86610: [ELF] Add new EM called EM_CSKY

[Zixuan Wu via Phabricator via llvm-commits]

zixuan-wu added a comment.

I think http://lists.llvm.org/pipermail/llvm-dev/2020-August/144587.html may answer your concern.



================
Comment at: llvm/include/llvm/BinaryFormat/ELF.h:315
   EM_VE = 251,            // NEC SX-Aurora VE
+  EM_CSKY = 252,          // C-SKY 32-bit processor
 };
----------------
MaskRay wrote:
> arsenm wrote:
> > This doesn't look registered? https://www.sco.com/developers/gabi/latest/ch4.eheader.html
> See the thread "Machine Request - 65816/65c816" in the generic-abi google group.
> binutils has the definition
> https://sourceware.org/legacy-ml/binutils/2018-05/msg00242.html
> and the value is known by several folks on generic-abi.
> 
> Unfortunately the website has been unmaintained for a few years now.
I find the page https://www.sco.com/developers/gabi/latest/ch4.eheader.html is out-of-date and have been unmaintained. You can check https://groups.google.com/g/generic-abi/c/qaPzp2lRzDA?pli=1. 

And the binutils have contained this EM_CSKY.




================
Comment at: llvm/test/Object/CSKY/elf-flags.yaml:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-readobj --file-headers %t | FileCheck -check-prefix=OBJ %s
----------------
MaskRay wrote:
> `llvm/unittests/Object/ELFObjectFileTest.cpp` may be more suitable. We don't need to teach llvm-readobj about every EM_* value.
Good, thank you. I will add a unittest at ELFObjectFileTest. And I think I can keep elf-flags.yaml for target flags check later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86610/new/

https://reviews.llvm.org/D86610