[PATCH] D86610: [ELF] Add new EM called EM_CSKY

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

This looks good to me, but I guess the target may need an official approval (from LLVM Foundation Board of Directors?) first.
>From very few reports on c-sky I can find on the Internet, the v1 and v2 of the chip csky uses the "c-sky" architecture. v3 uses RISC-V. I am a bit worrisome whether this organization backing the target will commit to maintain for a sufficiently long time in LLVM. (If you look at existing lib/Target/* targets, many have been there for 10 years. For the younger ones, I think there are commitments from the companies).



================
Comment at: llvm/include/llvm/BinaryFormat/ELF.h:315
   EM_VE = 251,            // NEC SX-Aurora VE
+  EM_CSKY = 252,          // C-SKY 32-bit processor
 };
----------------
arsenm wrote:
> This doesn't look registered? https://www.sco.com/developers/gabi/latest/ch4.eheader.html
See the thread "Machine Request - 65816/65c816" in the generic-abi google group.
binutils has the definition
https://sourceware.org/legacy-ml/binutils/2018-05/msg00242.html
and the value is known by several folks on generic-abi.

Unfortunately the website has been unmaintained for a few years now.


================
Comment at: llvm/test/Object/CSKY/elf-flags.yaml:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-readobj --file-headers %t | FileCheck -check-prefix=OBJ %s
----------------
`llvm/unittests/Object/ELFObjectFileTest.cpp` may be more suitable. We don't need to teach llvm-readobj about every EM_* value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86610/new/

https://reviews.llvm.org/D86610