[PATCH] D86571: [lld-macho][NFC] Handle GOT bindings and regular bindings more uniformly

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:109
-bool BindingSection::isNeeded() const {
-  return bindings.size() != 0 || in.got->isNeeded() ||
-         in.tlvPointers->isNeeded();
----------------
smeenai wrote:
> I get that we're accounting for the got and tlvPointers the same as all other bindings now, but how come we don't need the `bindings.size() != 0` check at all anymore?
oops -- I'd meant to move this method to the header, not delete it

(we don't have a test that checks to make sure we don't emit a BindingSection when we don't need one... not super important since it doesn't affect correctness, but I'll see if it's easy to add)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86571/new/

https://reviews.llvm.org/D86571