[PATCH] D86571: [lld-macho][NFC] Handle GOT bindings and regular bindings more uniformly

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM; this is a nice cleanup.



================
Comment at: lld/MachO/SyntheticSections.cpp:109
-bool BindingSection::isNeeded() const {
-  return bindings.size() != 0 || in.got->isNeeded() ||
-         in.tlvPointers->isNeeded();
----------------
I get that we're accounting for the got and tlvPointers the same as all other bindings now, but how come we don't need the `bindings.size() != 0` check at all anymore?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86571/new/

https://reviews.llvm.org/D86571