[PATCH] D86620: [PowerPC] Add Test for Paired Single Decoding

[Charlotte Delenk via Phabricator via llvm-commits]

DarkKirb created this revision.
Herald added subscribers: llvm-commits, steven.zhang, shchenz, kbarton, hiraditya, nemanjai.
Herald added a project: LLVM.
DarkKirb requested review of this revision.

This has uncovered multiple bugs with my previous implementation, namely that
ps_res and ps_frsqte had the wrong opcode and that the decoding for
immediate-offset loads and stores in ps_l* and ps_st* caused internal compiler
errors.

I couldn't reuse the logic from other immediate-offset code because

1. The register and the offset field are not right next to each other
2. The currently existing memri* asm operands are not 12 bit with unaligned offsets.

This commit also fixes the test suite for powerpc as it puts the new
instructions into a separate namespace (called Paired).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86620

Files:
  llvm/lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp
  llvm/lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp
  llvm/lib/Target/PowerPC/PPCInstrFormats.td
  llvm/lib/Target/PowerPC/PPCInstrInfo.td
  llvm/lib/Target/PowerPC/PPCInstrPaired.td
  llvm/test/MC/Disassembler/PowerPC/ppc32-paired.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86620.287958.patch
Type: text/x-patch
Size: 24008 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200826/abb18e35/attachment.bin>