[PATCH] D86565: [Attributor][FIX] Do not deduce noundef for dead positions

Shinji Okumura via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 14:42:36 PDT 2020


okura added a comment.

In D86565#2237287 <https://reviews.llvm.org/D86565#2237287>, @jdoerfert wrote:

> LGTM, one minor note. The test will be part of the module slice patch, I'm fairly certain this cannot be tested right now but it makes sense.

Sorry, I was wrong. `CheckBBLivenessOnly` should be `false` because if it is `true` we cannot catch the assumed liveness of e.g. returned position.
When I changed it to `true`, a new AAIsDead was registered in manifestation, and segfault happened. So I register them in `initialize`.
Some tests are affected by this change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86565/new/

https://reviews.llvm.org/D86565



More information about the llvm-commits mailing list