[PATCH] D86565: [Attributor][FIX] Do not deduce noundef for dead positions

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 14:36:39 PDT 2020


jdoerfert added a comment.

In D86565#2237295 <https://reviews.llvm.org/D86565#2237295>, @sstefan1 wrote:

> In D86565#2237287 <https://reviews.llvm.org/D86565#2237287>, @jdoerfert wrote:
>
>> LGTM, one minor note. The test will be part of the module slice patch, I'm fairly certain this cannot be tested right now but it makes sense.
>
> Maybe this can be tested if we actually address the TODO for AANoUndef in AAUB? I think with that, this can be caught in module pass?
>
> Just a suggestion.

Right. That should work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86565/new/

https://reviews.llvm.org/D86565



More information about the llvm-commits mailing list