[PATCH] D86524: [MC] [Win64EH] Update the AArch64/seh.s test slightly. NFC.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: efriedma, ssijaric, TomTan.
Herald added subscribers: danielkiss, kristof.beyls.
Herald added a project: LLVM.
mstorsjo requested review of this revision.

Update the comment stating the aim of the test - this is currently only checking that these assembler directives doesn't cause the assembler to fail, but the results of the testcase aren't particularly correct yet.

Remove bits of the testcase that are even less likely to be found in the wild (the .seh_startchained/.seh_endchained block), where the testcase currently doesn't really generate anything interesting anyway.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86524

Files:
  llvm/test/MC/AArch64/seh.s


Index: llvm/test/MC/AArch64/seh.s
===================================================================
--- llvm/test/MC/AArch64/seh.s
+++ llvm/test/MC/AArch64/seh.s
@@ -1,4 +1,4 @@
-// This test checks that the SEH directives emit the correct unwind data.
+// This test checks that the SEH directives don't cause the assembler to fail.
 
 // RUN: llvm-mc -triple aarch64-pc-win32 -filetype=obj %s | llvm-readobj -S -r - | FileCheck %s
 
@@ -15,7 +15,7 @@
 // CHECK-NEXT:   }
 // CHECK:        Section {
 // CHECK:          Name: .xdata
-// CHECK:          RawDataSize: 24
+// CHECK:          RawDataSize: 20
 // CHECK:          RelocationCount: 1
 // CHECK:          Characteristics [
 // CHECK-NEXT:       ALIGN_4BYTES
@@ -25,7 +25,7 @@
 // CHECK-NEXT:   }
 // CHECK:        Section {
 // CHECK:          Name: .pdata
-// CHECK:          RelocationCount: 6
+// CHECK:          RelocationCount: 4
 // CHECK:          Characteristics [
 // CHECK-NEXT:       ALIGN_4BYTES
 // CHECK-NEXT:       CNT_INITIALIZED_DATA
@@ -41,10 +41,8 @@
 // CHECK-NEXT:   Section (5) .pdata {
 // CHECK-NEXT:     0x0 IMAGE_REL_ARM64_ADDR32NB func
 // CHECK-NEXT:     0x4 IMAGE_REL_ARM64_ADDR32NB .xdata
-// CHECK-NEXT:     0x8 IMAGE_REL_ARM64_ADDR32NB func
+// CHECK-NEXT:     0x8 IMAGE_REL_ARM64_ADDR32NB smallFunc
 // CHECK-NEXT:     0xC IMAGE_REL_ARM64_ADDR32NB .xdata
-// CHECK-NEXT:     0x10 IMAGE_REL_ARM64_ADDR32NB smallFunc
-// CHECK-NEXT:     0x14 IMAGE_REL_ARM64_ADDR32NB .xdata
 // CHECK-NEXT:   }
 // CHECK-NEXT: ]
 
@@ -65,9 +63,6 @@
     .seh_handlerdata
     .long 0
     .text
-    .seh_startchained
-    .seh_endprologue
-    .seh_endchained
     add sp, sp, #24
     ret
     .seh_endproc


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86524.287626.patch
Type: text/x-patch
Size: 1684 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200825/204af79b/attachment.bin>