[PATCH] D86332: [SampleFDO] Enhance profile remapping support for inline instance

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

Hongtao, thanks for the review!



================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:438
+      const LineLocation &Loc, StringRef CalleeName,
+      SampleProfileReaderItaniumRemapper *Remapper = nullptr) const;
 
----------------
hoy wrote:
> Nit: Update comment with `Remapper`?
Updated.


================
Comment at: llvm/lib/ProfileData/SampleProf.cpp:223
+  if (Remapper) {
+    Remapper->clear();
+    Remapper->insert(CalleeName);
----------------
hoy wrote:
> Does this remove only the last callee name added to the the remapper? Maybe give a more explicit name for that?
Yes, it only removes the last callee name. I cannot find a good name so I just change the remapper to CalleeRemapper.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86332/new/

https://reviews.llvm.org/D86332