[PATCH] D86332: [SampleFDO] Enhance profile remapping support for inline instance

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

Nice to see the perf regression drops to around 1% with this change!



================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:438
+      const LineLocation &Loc, StringRef CalleeName,
+      SampleProfileReaderItaniumRemapper *Remapper = nullptr) const;
 
----------------
Nit: Update comment with `Remapper`?


================
Comment at: llvm/lib/ProfileData/SampleProf.cpp:223
+  if (Remapper) {
+    Remapper->clear();
+    Remapper->insert(CalleeName);
----------------
Does this remove only the last callee name added to the the remapper? Maybe give a more explicit name for that?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86332/new/

https://reviews.llvm.org/D86332