[PATCH] D85974: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples
Lang Hames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 21 14:38:21 PDT 2020
lhames added a comment.
In D85974#2229168 <https://reviews.llvm.org/D85974#2229168>, @sgraenitz wrote:
> Back to the review: I'd like to keep the test for the example and see how the build servers behave. Generally it might be useful to have tests for all the "LLJITWith..." examples right?
Sorry -- I LGTM'd earlier but forgot to hit "accept". I think LLJITWith... is a good home for this.
> Do you think it makes sense to land the patch on the weekend in order to keep the number of people getting annoyed by me breaking their builds at a minimum? :)
Up to you, but reverts are cheap -- if it works for you locally I'd say land away.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85974/new/
https://reviews.llvm.org/D85974
More information about the llvm-commits
mailing list