[PATCH] D85974: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples
Lang Hames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 21 14:37:04 PDT 2020
lhames added a comment.
In D85974#2229156 <https://reviews.llvm.org/D85974#2229156>, @sgraenitz wrote:
> I will get back to performance evaluation maybe in a few weeks and sure I am happy to share my progress.
>
>> If query handlers were dispatched rather than running on the thread that satisfies the last query dependence it should expose some new opportunities for concurrency.
>
> Indeed, that sounds promising. I hope it doesn't require adding more locking to the engine? In general, performance analysis only works in combination with comprehensive benchmark data. Maybe a good opportunity to create a benchmark suite for tracking both, single- and multi-threaded performance over time?
It wouldn't introduce new static locking points. To the extent that it enables extra concurrency there's more opportunities for lock contention, but that's a good thing. :)
I 100% agree on the benchmarking idea -- we definitely want one of those.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85974/new/
https://reviews.llvm.org/D85974
More information about the llvm-commits
mailing list