[PATCH] D73475: [X86] Make sure we do not clobber RBX with mwaitx when used as a base pointer.
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 21 11:14:29 PDT 2020
craig.topper added inline comments.
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:25820
}
+ case Intrinsic::x86_mwaitx: {
+ // If the current function needs the base pointer, RBX,
----------------
Can we just always use MWAITX_DAG and use the !hasBasePointer part of the custom inserter?
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:25838
+ unsigned Opcode = X86ISD::MWAITX_DAG;
+ SDValue Chain = DAG.getNode(Opcode, dl, {MVT::Other, MVT::Glue},
+ {Op->getOperand(0), Op->getOperand(2),
----------------
Is the Glue result needed?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73475/new/
https://reviews.llvm.org/D73475
More information about the llvm-commits
mailing list