[PATCH] D86344: [FileCheck] Move FileCheck implementation out of LLVMSupport into its own library

Raphael Isemann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 05:20:20 PDT 2020


teemperor created this revision.
teemperor added reviewers: thopre, davide, MaskRay, jhenderson.
Herald added subscribers: llvm-commits, kristina, hiraditya, arichardson, mgorny.
Herald added a project: LLVM.
teemperor requested review of this revision.

The actual FileCheck logic seems to be implemented in LLVMSupport. I don't see a good
reason for having FileCheck implemented there as it has a very specific use while LLVMSupport
is a dependency of pretty much every LLVM tool there is. In fact, the only use of FileCheck I
could find (outside the FileCheck tool and the FileCheck unit test) is a single call in GISelMITest.h.

This moves the FileCheck logic to its own LLVMFileCheck library. This way only FileCheck and
the GlobalISelTests now have a dependency on this code.


Repository:
  rL LLVM

https://reviews.llvm.org/D86344

Files:
  llvm/include/llvm/FileCheck/FileCheck.h
  llvm/include/llvm/Support/FileCheck.h
  llvm/include/llvm/module.modulemap
  llvm/lib/CMakeLists.txt
  llvm/lib/FileCheck/CMakeLists.txt
  llvm/lib/FileCheck/FileCheck.cpp
  llvm/lib/FileCheck/FileCheckImpl.h
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/FileCheck.cpp
  llvm/lib/Support/FileCheckImpl.h
  llvm/unittests/CMakeLists.txt
  llvm/unittests/CodeGen/GlobalISel/CMakeLists.txt
  llvm/unittests/CodeGen/GlobalISel/GISelMITest.h
  llvm/unittests/FileCheck/CMakeLists.txt
  llvm/unittests/FileCheck/FileCheckTest.cpp
  llvm/unittests/Support/CMakeLists.txt
  llvm/unittests/Support/FileCheckTest.cpp
  llvm/utils/FileCheck/CMakeLists.txt
  llvm/utils/FileCheck/FileCheck.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86344.287011.patch
Type: text/x-patch
Size: 7012 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200821/3724b04f/attachment.bin>


More information about the llvm-commits mailing list