[PATCH] D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 14:35:40 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCELFObjectWriter.cpp:424
+      default:
+        report_fatal_error("Unsupported Modifier for fixup_ppc_imm34.");
+      case MCSymbolRefExpr::VK_TPREL:
----------------
Is this unreachable? If yes, assert may be better


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83404/new/

https://reviews.llvm.org/D83404



More information about the llvm-commits mailing list