[PATCH] D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp accepted this revision as: stefanp.
stefanp added a comment.
This revision is now accepted and ready to land.

Only minor nits form me.
LGTM.



================
Comment at: llvm/test/CodeGen/PowerPC/pcrel-tls-local-exec.ll:5
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
+; RUN:   -mcpu=pwr10 -ppc-asm-full-reg-names --filetype=obj < %s | \
+; RUN:   llvm-objdump --mcpu=pwr10 -dr - | FileCheck %s --check-prefix=CHECK-O
----------------
I think you are missing `-enable-ppc-pcrel-tls` here and in the command above.


================
Comment at: llvm/test/MC/PowerPC/pcrel-tls-local-exec-address-load-reloc.s:13
+
+LocalExec:                              # @LocalExec
+	paddi 3, 13, x at TPREL, 0
----------------
nit:
You can remove the comment: `# @LocalExec`


================
Comment at: llvm/test/MC/PowerPC/pcrel-tls-local-exec-value-load-reloc.s:13
+
+LocalExecLoad:                          # @LocalExecLoad
+	paddi 3, 13, x at TPREL, 0
----------------
nit:
Similarly I think you can remove the comment `# @LocalExecLoad`.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83404/new/

https://reviews.llvm.org/D83404