[PATCH] D86294: [RFC] AMDGPU/GlobalISel: Look through copies in GIM_CheckOpcode and add post-isel hook

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/InstructionSelector.h:396
 
+using NewMIVector = SmallVector<MachineInstrBuilder, 4>;
 /// Provides the logic to select generic machine instructions.
----------------
Can't this still be inside the class? I.e. move it down two or three lines?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:2855-2856
+    NewMIVector &OutMIs) const {
+  if (OutMIs.size() != 1)
+    return;
+  TII.AdjustInstrPostInstrSelectionBase(*OutMIs[0], nullptr,
----------------
Why not call AdjustInstrPostInstrSelectionBase on each MI in OutMIs?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86294/new/

https://reviews.llvm.org/D86294