[PATCH] D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI]
Christopher Tetreault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 19 10:09:59 PDT 2020
ctetreau accepted this revision.
ctetreau added a comment.
This revision is now accepted and ready to land.
Fix that one straggler, then this LGTM.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1191
+ InstWidening getWideningDecision(Instruction *I, ElementCount VF) {
+ assert(!VF.Scalable && "invalid element count");
+ assert(VF.isVector() && "Expected VF >=2");
----------------
ctetreau wrote:
> The assert message is unclear. Change it to something like "scalable vectors not yet supported". If this function does not make sense for scalable vectors, then we should explicitly operate on FixedVectorType
looks like you missed this one
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85794/new/
https://reviews.llvm.org/D85794
More information about the llvm-commits
mailing list