[PATCH] D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI]
Francesco Petrogalli via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 18 13:17:53 PDT 2020
fpetrogalli added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:317
+static bool hasIrregularType(Type *Ty, const DataLayout &DL, ElementCount VF) {
+ assert(!VF.Scalable && "invalid number of elements");
// Determine if an array of VF elements of type Ty is "bitcast compatible"
----------------
ctetreau wrote:
> The assert message is unclear. Change it to something like "scalable vectors not yet supported".
>
> If this function does not make sense for scalable vectors, then we should explicitly operate on FixedVectorType
I think that this function makes sense also for scalable vectors.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85794/new/
https://reviews.llvm.org/D85794
More information about the llvm-commits
mailing list