[PATCH] D86150: [NFC][DebugInfo] Create InstructionOrdering helper class (1/4)

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 00:56:39 PDT 2020


Orlando added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:62
+public:
+  void initialize(const MachineFunction &MF);
+  void clear() { InstNumberMap.clear(); }
----------------
aprantl wrote:
> why isn't this a constructor? does it get initialized multiple times?
Sorry I should have said something in the description about this.

In D86151 I add an `InstructionOrdering` member to `DebugHandlerBase`. I then call `initialize` in `DebugHandlerBase::beginFunction`, and the object is passed by const ref to `trimVarLocs` and `validThroughout`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86150/new/

https://reviews.llvm.org/D86150



More information about the llvm-commits mailing list