[PATCH] D86150: [NFC][DebugInfo] Create InstructionOrdering helper class (1/4)

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:62
+public:
+  void initialize(const MachineFunction &MF);
+  void clear() { InstNumberMap.clear(); }
----------------
why isn't this a constructor? does it get initialized multiple times?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:168
+  InstructionOrdering Ordering;
+  Ordering.initialize(MF);
 
----------------
Hmm.. If we can make this a throwaway/RAII object I think I would prefer that


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86150/new/

https://reviews.llvm.org/D86150