[PATCH] D82603: AMDGPU: Implement waterfall loop for MIMG instructions with 256-bit SRsrc

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 15:43:18 PDT 2020


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:5075
+    if (SSamp && !RI.isSGPRClass(MRI.getRegClass(SSamp->getReg())))
+      loadSRsrcFromVGPR(*this, MI, *SSamp, MDT);
+
----------------
What about the SGPR offset? I guess this was broken before anyway


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82603/new/

https://reviews.llvm.org/D82603



More information about the llvm-commits mailing list