[PATCH] D86155: [OpenMPOpt][SplitMemTransfer] Moving the "wait" down

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D86155#2224474 <https://reviews.llvm.org/D86155#2224474>, @hamax97 wrote:

> In D86155#2224292 <https://reviews.llvm.org/D86155#2224292>, @jdoerfert wrote:
>
>> We have to check "mayReadMemory" as well I think.
>
> Is it really necessary?, I think we only care if the instruction writes to memory. If I add it, now only in `heaveComputation1` and `dataTransferOnly1` the runtime call is split. This because the immediate instructions after `__tgt_target_data_begin_mapper` in the other test functions is a `load`.

Not splitting in this example is OK. Load is a problem if the transfer is to the issuing device, store is always a problem.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86155/new/

https://reviews.llvm.org/D86155