[PATCH] D86155: [OpenMPOpt][SplitMemTransfer] Moving the "wait" down

Hamilton Tobon-Mosquera via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 11:18:40 PDT 2020


hamax97 added a comment.

In D86155#2224292 <https://reviews.llvm.org/D86155#2224292>, @jdoerfert wrote:

> We have to check "mayReadMemory" as well I think.

Is it really necessary?, I think we only care if the instruction writes to memory. If I add it, now only in `heaveComputation1` and `dataTransferOnly1` the runtime call is split. This because the immediate instructions after `__tgt_target_data_begin_mapper` in the other test functions is a `load`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86155/new/

https://reviews.llvm.org/D86155



More information about the llvm-commits mailing list