[PATCH] D85868: DAG: Don't pass 0 alignment value to allowsMisalignedMemoryAccesses

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:252
       if (NumMemOps && Op.allowOverlap() && NewVTSize < Size &&
           allowsMisalignedMemoryAccesses(
+              VT, DstAS, Op.isFixedDstAlign() ? Op.getDstAlign().value() : 1,
----------------
courbet wrote:
> There's actually an overload that takes an `Align`. The old version is scheduled to go away. So please use the overload:
> 
> ```
> allowsMisalignedMemoryAccesses( VT, DstAS, Op.isFixedDstAlign() ? Op.getDstAlign() : Align(1))
> ```
There isn't actually. The LLT version uses Align, but the SelectionDAG version does not


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85868/new/

https://reviews.llvm.org/D85868