[PATCH] D86044: [llvm-dwarfdump][test] Add a --statistics test for a DW_AT_artificial variable

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Ah, I see - variables are classified as artificial, constant, or local. Even though there's no artificial variable statistic, as such.

I think it might be better if the code tracked the total vars directly - rather than classifying them into 3 groups then merging those again later - if some code decides to have a 4th classification, this merging could get missed & become buggy, compared to maintaining it all along as a separate stat.

Also it looks like artificial parameters aren't getting tracking for all the other stuff - "NumParams", "NumParamTypes", "NumParamSourceLocations", "NumParamLocations"... which seems questionable. Wonder if there was any particular thinking around/justification for that in the original commits of this functionality.

(that said, I haven't had much to do with the Statistics code - so perhaps other folks have other ideas)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86044/new/

https://reviews.llvm.org/D86044