[PATCH] D86044: [llvm-dwarfdump][test] Add a --statistics test for a DW_AT_artificial variable

Mon Aug 17 12:22:15 PDT 2020

MaskRay added a comment.

In D86044#2222168 <https://reviews.llvm.org/D86044#2222168>, @dblaikie wrote:

> In D86044#2222156 <https://reviews.llvm.org/D86044#2222156>, @MaskRay wrote:
>
>> In D86044#2222140 <https://reviews.llvm.org/D86044#2222140>, @dblaikie wrote:
>>
>>> Sorry, looking at the test now - is there any particular reason to test this case in particular? Looks like there's no particular statistics for artificial variables & I guess the statistics code doesn't look at this property one way or another?
>>
>> Statistics.cpp:343 has a different `DW_AT_artificial` use. If we change Statistics.cpp:564 to use NumArtificial in IsFunction case, a DW_AT_artificial variable will be significant.
>
> Not sure I follow, sorry. Are you planning to add a new statistic?

No. The new test checks that `this` (even if not written) is counted as a source variable.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86044/new/

https://reviews.llvm.org/D86044