[PATCH] D85781: [BPI] Improve static heuristics for integer comparisons

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 11:39:24 PDT 2020


xbolva00 added a comment.

In D85781#2222094 <https://reviews.llvm.org/D85781#2222094>, @davidxl wrote:

> I suggest the following steps to commit this patch:
>
> 1. add an internal option to turn on the new heuristics with default to
>
> false;
>
> 2. commit the patch with minimal test changes;
>
> 3. for each target affected, explicitly modify the tests with the option
>
> turned on and ask the target owner to examine the changes
>
> 4. once all tests are fixed (with option explicitly turned on), flip the
>
> option on by default;
>
> 5. remove the explicit option added in step 3).

Good idea, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85781/new/

https://reviews.llvm.org/D85781



More information about the llvm-commits mailing list