[PATCH] D85781: [BPI] Improve static heuristics for integer comparisons

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 11:36:06 PDT 2020


I suggest the following steps to commit this patch:

1) add an internal option to turn on the new heuristics with default to
false;
2) commit the patch with minimal test changes;

3) for each target affected, explicitly modify the tests with the option
turned on and ask the target owner to examine the changes
4) once all tests are fixed (with option explicitly turned on), flip the
option on by default;
5) remove the explicit option added in step 3).


On Mon, Aug 17, 2020 at 11:31 AM Dávid Bolvanský via Phabricator <
reviews at reviews.llvm.org> wrote:

> xbolva00 added a comment.
>
> Feedback arrived after things landed. Should I revert everything and split
> it to many patches and reland?
>
>
> https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20200810/819028.html
>
> Strange (?). I did not receive this mail. Next time please comment on Phab.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D85781/new/
>
> https://reviews.llvm.org/D85781
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200817/68f14a8c/attachment.html>


More information about the llvm-commits mailing list