[PATCH] D84641: AMDGPU/GlobalISel: Fix selection of s1/s16 G_[F]CONSTANT
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 17 06:27:34 PDT 2020
foad added a comment.
It's hard to see which test diffs are relevant. Could you commit some changes (like tweaks to the implicit operands on S_ENDPGM) separately?
================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-fconstant.mir:140-141
+ ; Test without already assigned register class
+ %4:vgpr(s16) = G_FCONSTANT half 1.0
+ %5:vgpr(s16) = G_FCONSTANT half 8.0
$vgpr0 = COPY %2
----------------
I'm confused - how are these lines testing anything different than lines 134-135?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84641/new/
https://reviews.llvm.org/D84641
More information about the llvm-commits
mailing list