[PATCH] D85786: [lld-macho] Emit load command LC_BUILD_VERSION

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: lld/test/MachO/lc-build-version.s:13
+# CHECK-NEXT: tool ld
+# CHECK-NEXT: version {{[1-9][0-9]\.[0-9]+}}
+# CHECK-NEXT: Load command [[#]]
----------------
This macro is a bit overly restrictive: our version of lld does not start with a leading 1 and fails this test.

I relaxed it in https://github.com/llvm/llvm-project/commit/22cbe40fa99795766f352c08a7c0748704c9d2d5 for now,  if you would like a more specific checks I can propose this instead https://reviews.llvm.org/D86026 ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85786/new/

https://reviews.llvm.org/D85786