[PATCH] D85594: [MachO] Add skeletal support for DriverKit platform

[Cyndy Ishida via Phabricator via llvm-commits]

cishida added inline comments.


================
Comment at: llvm/lib/TextAPI/MachO/Platform.cpp:52
                                            : PlatformKind::watchOS;
     // TODO: add bridgeOS once in llvm::Triple
   }
----------------
gkm wrote:
> cishida wrote:
> > DriverKit case should be included 
> @cishida, a case here depends on first defining `DriverKit` for `enum Triple::OSType` in `llvm/include/llvm/ADT/Triple.h`, which does not yet exist. (Same for `BridgeOS` according to your comment above). I see that properly supporting these `Triple::OSType` enums requires knowing minimum OS versions in several contexts, and knowing more about the platforms than I do.
> 
> May I commit this diff as-is, without `Triple::OSType::DriverKit`, and leave that to you?
SGTM! In the revision that lands, could you just include driverkit in the `TODO` comment? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85594/new/

https://reviews.llvm.org/D85594